Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support returning body from another request #2161

Merged
merged 1 commit into from
May 8, 2023

Conversation

andrzejressel
Copy link
Contributor

I guess handling of AsyncBody was incorrent?

Fixes #2157
/claim #2157

@ex0ns
Copy link
Contributor

ex0ns commented May 8, 2023

I have tested this on the code I submitted in the issue and it now works as expected

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.29 🎉

Comparison is base (b406af8) 66.81% compared to head (a60ff8a) 67.10%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2161      +/-   ##
==========================================
+ Coverage   66.81%   67.10%   +0.29%     
==========================================
  Files         141      142       +1     
  Lines        6011     6196     +185     
  Branches      232      265      +33     
==========================================
+ Hits         4016     4158     +142     
- Misses       1995     2038      +43     
Impacted Files Coverage Δ
...rc/main/scala/zio/http/netty/NettyBodyWriter.scala 59.25% <75.00%> (+19.25%) ⬆️

... and 46 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdegoes jdegoes merged commit 37b94b9 into zio:main May 8, 2023
@jdegoes
Copy link
Member

jdegoes commented May 8, 2023

Thanks for your contribution!

@andrzejressel andrzejressel deleted the support_returning_request branch May 8, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netty error when trying to forward the Response of a client
4 participants