Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required traces to the package zio.http.netty #2322

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Add required traces to the package zio.http.netty #2322

merged 2 commits into from
Jul 28, 2023

Conversation

gregor-rayman
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.05% ⚠️

Comparison is base (fd7a239) 63.68% compared to head (3ff75cf) 63.63%.
Report is 2 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2322      +/-   ##
==========================================
- Coverage   63.68%   63.63%   -0.05%     
==========================================
  Files         136      136              
  Lines        7195     7167      -28     
  Branches     1261     1273      +12     
==========================================
- Hits         4582     4561      -21     
+ Misses       2613     2606       -7     
Files Changed Coverage Δ
...rc/main/scala/zio/http/netty/AsyncBodyReader.scala 84.37% <ø> (ø)
...c/main/scala/zio/http/netty/ChannelFactories.scala 48.00% <ø> (ø)
...rc/main/scala/zio/http/netty/EventLoopGroups.scala 33.33% <ø> (ø)
...http/src/main/scala/zio/http/netty/NettyBody.scala 70.83% <ø> (ø)
...rc/main/scala/zio/http/netty/NettyBodyWriter.scala 42.85% <ø> (-25.72%) ⬇️
...p/src/main/scala/zio/http/netty/NettyChannel.scala 61.53% <ø> (ø)
...tp/src/main/scala/zio/http/netty/NettyConfig.scala 42.85% <ø> (ø)
...ain/scala/zio/http/netty/NettyCookieEncoding.scala 100.00% <ø> (ø)
...ain/scala/zio/http/netty/NettyFutureExecutor.scala 85.71% <ø> (ø)
.../src/main/scala/zio/http/netty/NettyResponse.scala 100.00% <ø> (ø)
... and 21 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdegoes jdegoes merged commit 812ac8e into zio:main Jul 28, 2023
987Nabil pushed a commit to 987Nabil/zio-http that referenced this pull request Jul 28, 2023
* Add required traces to the package zio.http.netty

* remove import zio.stacktracer.TracingImplicits.disableAutoTrace
from NettyDriver.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants