Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required traces to the http package #2326

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Add required traces to the http package #2326

merged 2 commits into from
Jul 28, 2023

Conversation

jaliss
Copy link
Contributor

@jaliss jaliss commented Jul 27, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 63.15% and project coverage change: -0.39% ⚠️

Comparison is base (fd7a239) 63.68% compared to head (3abc548) 63.29%.
Report is 2 commits behind head on main.

❗ Current head 3abc548 differs from pull request most recent head 781a686. Consider uploading reports for the commit 781a686 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2326      +/-   ##
==========================================
- Coverage   63.68%   63.29%   -0.39%     
==========================================
  Files         136      136              
  Lines        7195     7076     -119     
  Branches     1261     1243      -18     
==========================================
- Hits         4582     4479     -103     
+ Misses       2613     2597      -16     
Files Changed Coverage Δ
zio-http/src/main/scala/zio/http/Boundary.scala 77.27% <ø> (-0.99%) ⬇️
zio-http/src/main/scala/zio/http/Channel.scala 9.09% <ø> (ø)
zio-http/src/main/scala/zio/http/Driver.scala 0.00% <ø> (ø)
zio-http/src/main/scala/zio/http/Form.scala 86.11% <ø> (-5.67%) ⬇️
zio-http/src/main/scala/zio/http/FormField.scala 88.00% <ø> (-2.00%) ⬇️
zio-http/src/main/scala/zio/http/Handler.scala 65.19% <ø> (+0.29%) ⬆️
...o-http/src/main/scala/zio/http/HandlerAspect.scala 70.19% <ø> (ø)
zio-http/src/main/scala/zio/http/Headers.scala 87.09% <0.00%> (ø)
zio-http/src/main/scala/zio/http/HttpError.scala 75.00% <ø> (ø)
zio-http/src/main/scala/zio/http/Request.scala 42.85% <ø> (-1.59%) ⬇️
... and 9 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdegoes jdegoes merged commit e8dd351 into zio:main Jul 28, 2023
987Nabil pushed a commit to 987Nabil/zio-http that referenced this pull request Jul 28, 2023
* Add required traces to the http package

* removed comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants