Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL string interpolation macro #2331

Merged
merged 2 commits into from
Jul 28, 2023
Merged

URL string interpolation macro #2331

merged 2 commits into from
Jul 28, 2023

Conversation

vigoo
Copy link
Contributor

@vigoo vigoo commented Jul 27, 2023

No description provided.

@vigoo
Copy link
Contributor Author

vigoo commented Jul 27, 2023

Note: it is not possible to check compile time that the URL is valid if there are injected string-typed variables in the interpolated string. The macro tries a best effort check, replacing the run time values with examples of the corresponding type.

When used on a static string, it is guaranteed to not throw any errors and always construct a valid URL.

@github-actions github-actions bot added the maintenance Chore or Maintenance tasks label Jul 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (812ac8e) 63.17% compared to head (0a0b6ab) 63.18%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2331      +/-   ##
==========================================
+ Coverage   63.17%   63.18%   +0.01%     
==========================================
  Files         136      136              
  Lines        7057     7057              
  Branches     1254     1254              
==========================================
+ Hits         4458     4459       +1     
+ Misses       2599     2598       -1     
Files Changed Coverage Δ
zio-http/src/main/scala/zio/http/URL.scala 84.61% <ø> (+0.85%) ⬆️
zio-http/src/main/scala/zio/http/package.scala 66.66% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigoo vigoo merged commit dd07127 into main Jul 28, 2023
@vigoo vigoo deleted the url-macro-2 branch July 28, 2023 10:47
987Nabil pushed a commit to 987Nabil/zio-http that referenced this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Chore or Maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants