Automatically validate request body using Schema.validate
#2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamareynolds
force-pushed
the
2274-automatic-schema-validation
branch
2 times, most recently
from
75027f0 to
dad30e9
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2360 +/- ##
==========================================
+ Coverage 63.21% 63.22% +0.01%
==========================================
Files 135 135
Lines 7032 7038 +6
Branches 1185 1183 -2
==========================================
+ Hits 4445 4450 +5
- Misses 2587 2588 +1
☔ View full report in Codecov by Sentry. |
Uses the `Schema.validate` method from `zio-schema` to validate the body of a request based on the schema of the input type. If schema validation fails, `HttpCodecError.InvalidEntity` is passed to the error channel, indicating that the body is well-formed, but contains invalid values in one or more fields. A `wrap` method is included for `InvalidEntity` which simplifies the process of converting `Schema.validate`'s output (`Chunk[ValidationError]`) to `InvalidEntity` in a consistent way. resolves zio#2274
williamareynolds
force-pushed
the
2274-automatic-schema-validation
branch
from
dad30e9 to
6764704
Compare
williamareynolds
changed the title
Schema.validate
williamareynolds
requested review from
amitksingh1490,
jdegoes,
vigoo and
adamgfraser
as code owners
vigoo
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the
Schema.validatemethod fromzio-schemato validate the bodyof a request based on the schema of the input type. If schema validation
fails,
HttpCodecError.InvalidEntityis passed to the error channel,indicating that the body is well-formed, but contains invalid values in
one or more fields. A
wrapmethod is included forInvalidEntitywhich simplifies the process of converting
Schema.validate'soutput (
Chunk[ValidationError]) toInvalidEntityin a consistentway.
/claim #2274
/split @allaryin