Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lax environment requirement when transforming a Handler #2390

Conversation

myazinn
Copy link
Contributor

@myazinn myazinn commented Aug 18, 2023

Env1 <: Env when transforming Routes / Handler seems too restrictive. Perhaps I'm missing something, but I see no reason why transformation can't change / eliminate it completely.

@myazinn
Copy link
Contributor Author

myazinn commented Aug 18, 2023

Failing build seems unrelated to my changes, I see it happens in other PRs too

@myazinn myazinn force-pushed the lax-environment-requirement-when-transforming-Handlers branch from 3911093 to 138d8e7 Compare August 19, 2023 15:01
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.09% ⚠️

Comparison is base (33ed169) 63.42% compared to head (138d8e7) 63.34%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2390      +/-   ##
==========================================
- Coverage   63.42%   63.34%   -0.09%     
==========================================
  Files         137      137              
  Lines        7109     7109              
  Branches     1267     1267              
==========================================
- Hits         4509     4503       -6     
- Misses       2600     2606       +6     
Files Changed Coverage Δ
zio-http/src/main/scala/zio/http/Route.scala 72.00% <ø> (ø)
zio-http/src/main/scala/zio/http/Routes.scala 76.47% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdegoes jdegoes merged commit 1071399 into zio:main Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants