Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: case-insensitive FormField headers #2460

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

jgranstrom
Copy link
Contributor

Some clients send FormField headers in lower case. However we seem to require them to be capitalized. I can't find a clear spec for headers in this context, but from headers in general we can probably expect it to vary. One example where we're incompatible is react-native.

@jdegoes jdegoes closed this Sep 27, 2023
@jdegoes jdegoes reopened this Sep 27, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1408f9c) 64.28% compared to head (26d53e1) 64.80%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2460      +/-   ##
==========================================
+ Coverage   64.28%   64.80%   +0.51%     
==========================================
  Files         135      135              
  Lines        7101     7129      +28     
  Branches     1211     1185      -26     
==========================================
+ Hits         4565     4620      +55     
+ Misses       2536     2509      -27     
Files Coverage Δ
zio-http/src/main/scala/zio/http/MediaType.scala 96.55% <100.00%> (+0.12%) ⬆️
.../src/main/scala/zio/http/codec/RichTextCodec.scala 88.58% <100.00%> (+4.52%) ⬆️
zio-http/src/main/scala/zio/http/FormField.scala 88.00% <75.00%> (ø)
zio-http/src/main/scala/zio/http/Header.scala 63.46% <92.72%> (+2.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdegoes jdegoes merged commit 5906d30 into zio:main Sep 27, 2023
18 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants