feat: Allow dynamic schema in openapi #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Openapi just constrains the possible values, but they are always JSON. In case of dynamic schema we do not know anything about the possible values, so we simply remove all constraints.
runtologist
requested review from
amitksingh1490,
jdegoes,
vigoo,
adamgfraser and
987Nabil
as code owners
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2543 +/- ##
==========================================
- Coverage 64.28% 64.27% -0.01%
==========================================
Files 138 138
Lines 7979 7980 +1
Branches 1488 1474 -14
==========================================
Hits 5129 5129
- Misses 2850 2851 +1 ☔ View full report in Codecov by Sentry. |
jdegoes
approved these changes
Dec 7, 2023
|
@runtologist Good to merge when build is passing. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openapi just constrains the possible values, but they are always JSON. In case of dynamic schema we do not know anything about the possible values, so we simply remove all constraints.