Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: htmx attributes #2589

Merged
merged 8 commits into from
Jan 13, 2024
Merged

feat: htmx attributes #2589

merged 8 commits into from
Jan 13, 2024

Conversation

neo773
Copy link
Contributor

@neo773 neo773 commented Jan 6, 2024

This PR adds HTMX Attributes in a zio.http.htmx package

/closes #2539
/claim #2539

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12f6b99) 64.70% compared to head (26d000f) 64.70%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2589   +/-   ##
=======================================
  Coverage   64.70%   64.70%           
=======================================
  Files         140      140           
  Lines        8468     8468           
  Branches     1547     1547           
=======================================
  Hits         5479     5479           
  Misses       2989     2989           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@987Nabil 987Nabil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the ticket, the impl. has to be done in a subproject

@neo773
Copy link
Contributor Author

neo773 commented Jan 7, 2024

@987Nabil
Hi,
Sorry about that this was my first time using Scala lang.
About the structure do we want it like this?
zio-http/src/main/scala/zio/htmx

@987Nabil
Copy link
Contributor

987Nabil commented Jan 7, 2024

@neo773 Take a look in the build.sbt file. There are different modules defined. For example you can also find zioHttpGen or zioHttpTestkit. You need to create a module like that and move the code into that module.

You can also check the sbt docs to understand sbt modules better.

@neo773
Copy link
Contributor Author

neo773 commented Jan 7, 2024

@neo773 Take a look in the build.sbt file. There are different modules defined. For example you can also find zioHttpGen or zioHttpTestkit. You need to create a module like that and move the code into that module.

You can also check the sbt docs to understand sbt modules better.

Got it, thank you.

@neo773
Copy link
Contributor Author

neo773 commented Jan 7, 2024

@987Nabil
I pushed a new commit that moves the code into subproject.
Could you review it when you're available?

P.S For some reason the CI seems to be broken on all PRs might wanna investigate that

Thanks.

@vigoo
Copy link
Contributor

vigoo commented Jan 8, 2024

To fix the github CI error, run sbt githubWorkflowGenerate to regenerate its definition (as it suggests somewhere near the end of the long error output)

build.sbt Show resolved Hide resolved
@neo773 neo773 requested a review from vigoo January 8, 2024 17:18
@neo773
Copy link
Contributor Author

neo773 commented Jan 12, 2024

@vigoo
Hi,
Was wondering is there anything else you need to merge this?

@vigoo
Copy link
Contributor

vigoo commented Jan 13, 2024

No I was just waiting for CI to pass

@vigoo vigoo merged commit 93885b2 into zio:main Jan 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please can you add htmx attributes to zio html
4 participants