-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OpenAPI example extraction #2635
Conversation
@jdegoes I missed it, because it was missing from the parameters of |
141d978
to
0ea8bca
Compare
dd2338b
to
7a860ec
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2635 +/- ##
==========================================
+ Coverage 64.84% 65.38% +0.54%
==========================================
Files 144 144
Lines 8488 8407 -81
Branches 1582 1532 -50
==========================================
- Hits 5504 5497 -7
+ Misses 2984 2910 -74 ☔ View full report in Codecov by Sentry. |
7a860ec
to
748832b
Compare
fixes #2609
/claim #2609
@jdegoes I see how I can deconstruct tuple examples for combined codecs. But for alternation, we don't have a type class that helps us to deconstruct.
I would add in the docs, that we don't support this for open api gen and that instead of calling
inExamples
on the endpoint, ppl should callContentCodec.content[A].examples(...) | ContentCodec.content[B].examples(...)
.wdyt?