Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI code gen collections fix (#2620) #2643

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

987Nabil
Copy link
Contributor

fixes #2620
/claim #2620

fixes #2621
/claim #2621

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (49d4aa4) 65.12% compared to head (984d705) 65.26%.
Report is 1 commits behind head on main.

Files Patch % Lines
...n/scala/zio/http/endpoint/openapi/OpenAPIGen.scala 83.33% 3 Missing ⚠️
...n/scala/zio/http/endpoint/openapi/JsonSchema.scala 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2643      +/-   ##
==========================================
+ Coverage   65.12%   65.26%   +0.14%     
==========================================
  Files         144      144              
  Lines        8386     8427      +41     
  Branches     1498     1529      +31     
==========================================
+ Hits         5461     5500      +39     
- Misses       2925     2927       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@987Nabil 987Nabil force-pushed the open-api-code-gen-primitives-array branch 2 times, most recently from 7b1dcae to 40f9e34 Compare January 21, 2024 07:26
@987Nabil 987Nabil force-pushed the open-api-code-gen-primitives-array branch from 40f9e34 to 7d9591c Compare January 21, 2024 22:52
@987Nabil 987Nabil force-pushed the open-api-code-gen-primitives-array branch from 7d9591c to 984d705 Compare January 21, 2024 22:53
@987Nabil 987Nabil enabled auto-merge (squash) January 21, 2024 22:55
@987Nabil 987Nabil merged commit 5c9b8c7 into zio:main Jan 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants