Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only write non default values to OpenAPI Json (#2549) #2661

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

987Nabil
Copy link
Contributor

@987Nabil 987Nabil commented Feb 3, 2024

Sorted maps for OpenAPI for stable json generation (#2549)

fixes #2549
/claim #2549

Sorted maps for OpenAPI for stable json generation (zio#2549)
@codecov-commenter
Copy link

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (aecd87c) 65.37% compared to head (b3ffeac) 65.28%.

Files Patch % Lines
...main/scala/zio/http/endpoint/openapi/OpenAPI.scala 54.54% 20 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2661      +/-   ##
==========================================
- Coverage   65.37%   65.28%   -0.10%     
==========================================
  Files         144      144              
  Lines        8448     8468      +20     
  Branches     1531     1543      +12     
==========================================
+ Hits         5523     5528       +5     
- Misses       2925     2940      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdegoes jdegoes merged commit 20591e0 into zio:main Feb 7, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement of JSON Schema generation
3 participants