Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryOps #2671

Merged
merged 1 commit into from
Feb 12, 2024
Merged

QueryOps #2671

merged 1 commit into from
Feb 12, 2024

Conversation

987Nabil
Copy link
Contributor

@987Nabil 987Nabil commented Feb 8, 2024

fixes #2662
/claim #2662

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (21989c9) 64.55% compared to head (66e950d) 64.54%.

❗ Current head 66e950d differs from pull request most recent head 2ea8b47. Consider uploading reports for the commit 2ea8b47 to get more accurate results

Files Patch % Lines
...c/main/scala/zio/http/internal/QueryModifier.scala 76.92% 3 Missing ⚠️
...-http/shared/src/main/scala/zio/http/Request.scala 0.00% 2 Missing ⚠️
...rc/main/scala/zio/http/internal/QueryGetters.scala 85.71% 2 Missing ⚠️
zio-http/shared/src/main/scala/zio/http/Form.scala 50.00% 1 Missing ⚠️
...p/shared/src/main/scala/zio/http/QueryParams.scala 87.50% 1 Missing ⚠️
zio-http/shared/src/main/scala/zio/http/URL.scala 50.00% 1 Missing ⚠️
...-http/shared/src/main/scala/zio/http/ZClient.scala 0.00% 1 Missing ⚠️
...scala/zio/http/codec/internal/EncoderDecoder.scala 66.66% 1 Missing ⚠️
...src/main/scala/zio/http/internal/QueryChecks.scala 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2671      +/-   ##
==========================================
- Coverage   64.55%   64.54%   -0.01%     
==========================================
  Files         145      148       +3     
  Lines        8607     8619      +12     
  Branches     1521     1511      -10     
==========================================
+ Hits         5556     5563       +7     
- Misses       3051     3056       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@987Nabil 987Nabil changed the title Flaky JS Test QueryOps Feb 8, 2024
This enables calling query parameter operators on `Request` directly
@jdegoes jdegoes merged commit fb21d14 into zio:main Feb 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Request query param handling
3 participants