Simplify style attributes #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnspade
commented
Feb 9, 2024
| @@ -49,7 +49,7 @@ trait Attributes { | |||
|
|
|||
| final def citeAttr: PartialAttribute[String] = PartialAttribute("cite") | |||
|
|
|||
| final def classAttr: PartialAttribute[List[String]] = PartialAttribute("class") | |||
| final def classAttr: PartialAttribute[String] = PartialAttribute("class") | |||
johnspade
force-pushed
the
simplify-css-attrs
branch
from
8541c38 to
7a430ff
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2675 +/- ##
==========================================
- Coverage 64.55% 64.52% -0.03%
==========================================
Files 145 145
Lines 8607 8607
Branches 1521 1571 +50
==========================================
- Hits 5556 5554 -2
- Misses 3051 3053 +2 ☔ View full report in Codecov by Sentry. |
johnspade
requested review from
jdegoes,
vigoo,
adamgfraser and
987Nabil
as code owners
jdegoes
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the age of Tailwind and long class chains in HTML, it's a bit cumbersome to wrap every class name in quotes, especially when copying styles and classes from tutorials or documentation. This PR changes the value type to
Stringforclassandstyleattributes in the HTML templates.