Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Reference Section on Sidebar #2785

Merged
merged 11 commits into from
Apr 23, 2024
Merged

Conversation

khajavi
Copy link
Member

@khajavi khajavi commented Apr 20, 2024

Restructured the sidebar to have a reference section

image

@khajavi khajavi marked this pull request as ready for review April 20, 2024 19:44
@daveads
Copy link
Contributor

daveads commented Apr 21, 2024

@khajavi my pr is already doing this

#2780

@khajavi
Copy link
Member Author

khajavi commented Apr 21, 2024

@daveads No problem! If your work merged before this PR, I'll update this PR to reflect your work and merge only the differences.

@khajavi khajavi marked this pull request as draft April 21, 2024 13:00
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.93%. Comparing base (c2f754e) to head (3cdf27d).
Report is 6 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2785      +/-   ##
==========================================
- Coverage   65.02%   64.93%   -0.09%     
==========================================
  Files         153      154       +1     
  Lines        8929     8976      +47     
  Branches     1622     1630       +8     
==========================================
+ Hits         5806     5829      +23     
- Misses       3123     3147      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khajavi khajavi marked this pull request as ready for review April 22, 2024 12:37
@khajavi
Copy link
Member Author

khajavi commented Apr 22, 2024

@jdegoes It is ready for review!

@daveads
Copy link
Contributor

daveads commented Apr 22, 2024

@daveads No problem! If your work merged before this PR, I'll update this PR to reflect your work and merge only the differences.

sure

@jdegoes jdegoes merged commit 29ff8f6 into zio:main Apr 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants