-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to check if the ZIO Runtime is propagated to req execution #2809
Conversation
@987Nabil it seems there's a flaky test that keeps failing. Is this a new test? I don't remember having it fail so many times in a row |
@kyri-petrou I had some issues on my PR too. I'll take a look soonish, but I am not a the PC rn |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2809 +/- ##
=======================================
Coverage 64.28% 64.28%
=======================================
Files 155 155
Lines 9086 9086
Branches 1586 1586
=======================================
Hits 5841 5841
Misses 3245 3245 ☔ View full report in Codecov by Sentry. |
Head branch was pushed to by a user without write access
@@ -311,7 +311,7 @@ object FormSpec extends ZIOHttpSpec { | |||
) | |||
} | |||
} @@ samples(10), | |||
) | |||
) @@ sequential |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marked this test suite as sequential hoping it'll fix the flakiness
@987Nabil the test issue is gone now that I made the test suite run sequentially, but the coverage action is hanging due to an issue with the CI setup:
|
Followup of #2807, adding a couple of tests to ensure that we're properly propagating the bootstrapped runtime to the request execution