Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to check if the ZIO Runtime is propagated to req execution #2809

Merged
merged 6 commits into from
May 2, 2024

Conversation

kyri-petrou
Copy link
Collaborator

Followup of #2807, adding a couple of tests to ensure that we're properly propagating the bootstrapped runtime to the request execution

@987Nabil 987Nabil enabled auto-merge (squash) April 27, 2024 10:19
@kyri-petrou
Copy link
Collaborator Author

@987Nabil it seems there's a flaky test that keeps failing. Is this a new test? I don't remember having it fail so many times in a row

@987Nabil
Copy link
Contributor

@kyri-petrou I had some issues on my PR too. I'll take a look soonish, but I am not a the PC rn

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.28%. Comparing base (65dc08d) to head (bd8a330).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2809   +/-   ##
=======================================
  Coverage   64.28%   64.28%           
=======================================
  Files         155      155           
  Lines        9086     9086           
  Branches     1586     1586           
=======================================
  Hits         5841     5841           
  Misses       3245     3245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

auto-merge was automatically disabled April 30, 2024 00:31

Head branch was pushed to by a user without write access

@@ -311,7 +311,7 @@ object FormSpec extends ZIOHttpSpec {
)
}
} @@ samples(10),
)
) @@ sequential
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marked this test suite as sequential hoping it'll fix the flakiness

@kyri-petrou
Copy link
Collaborator Author

@987Nabil the test issue is gone now that I made the test suite run sequentially, but the coverage action is hanging due to an issue with the CI setup:

{'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

@987Nabil 987Nabil merged commit 0c23f59 into zio:main May 2, 2024
25 checks passed
@kyri-petrou kyri-petrou deleted the add-runtime-tests branch May 2, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants