Implement streaming of multipart field data #2899
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #2734
/claim #2734
With this PR, we enable streaming of multipart field data by handling each chunk emitted by the input ZStream separately, and optionally flushing the buffer when the last byte(s) don't match the boundary.
I have a small concern with this approach though; in cases that request streaming is enabled, the output stream will be emitting individual bytes which can be quite bad for performance. I'm thinking we should potentially make this behaviour configurable via an extra argument to the
StreamingForm
case class and disable it by default. @jdegoes @khajavi what do you think?