Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2941: Cors, accessControlAllowHeaders in option request (prepend pre… #2943

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

jgoday
Copy link
Contributor

@jgoday jgoday commented Jul 4, 2024

#2941 related.
/claim #2941

The problem seems to be that the options routes, which handle the cors preflight request, were being added last, so the corsHeaders was not being correctly called ...

(routes @@ aspect) :+ optionsRoute

Two tests have been added to CorsSpecs to represent the problem reported by the related issue:

  • OPTIONS request with allowAllHeaders server config
  • OPTIONS request with no headers allowed in server config

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.81%. Comparing base (e9f1c02) to head (f384fa1).
Report is 7 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2943      +/-   ##
==========================================
+ Coverage   64.78%   64.81%   +0.02%     
==========================================
  Files         157      157              
  Lines        9395     9405      +10     
  Branches     1743     1672      -71     
==========================================
+ Hits         6087     6096       +9     
- Misses       3308     3309       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

algora-pbc bot commented Jul 30, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

@987Nabil 987Nabil merged commit 4f94eef into zio:main Aug 16, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants