Remove route builder #3115
Merged
Remove route builder #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
987Nabil
force-pushed
the
remove-route-builder
branch
from
8bf9ae7 to
f064483
Compare
|
@987Nabil You referenced the wrong ticket? |
|
I removed the route builder, since it is not needed anymore. Also I enabled Env access for the zio effects that handle errors on |
|
@jdegoes it fixes both |
987Nabil
commented
Sep 9, 2024
| @@ -53,7 +53,9 @@ sealed trait Route[-Env, +Err] { self => | |||
| final def handleError(f: Err => Response)(implicit trace: Trace): Route[Env, Nothing] = | |||
| self.handleErrorCauseZIO(c => ErrorResponseConfig.configRef.get.map(Response.fromCauseWith(c, _)(f))) | |||
|
|
|||
| final def handleErrorZIO(f: Err => ZIO[Any, Nothing, Response])(implicit trace: Trace): Route[Env, Nothing] = | |||
| final def handleErrorZIO[Env1 <: Env]( | |||
| final def handleErrorCauseZIO( | ||
| f: Cause[Err] => ZIO[Any, Nothing, Response], | ||
| )(implicit trace: Trace): Route[Env, Nothing] = | ||
| final def handleErrorCauseZIO[Env1 <: Env]( |
jdegoes
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2870
/claim #2870