Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Remove error type from SocketApp #769

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

tusharmath
Copy link
Collaborator

@tusharmath tusharmath commented Jan 6, 2022

SocketApp doesn't provide a way to catch errors. So adding an additional type-param for error doesn't add much value.

@github-actions github-actions bot added enhancement New feature or request maintenance Chore or Maintenance tasks labels Jan 6, 2022
@tusharmath tusharmath added Breaking Change and removed enhancement New feature or request labels Jan 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2022

Codecov Report

Merging #769 (502c718) into main (df11745) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #769   +/-   ##
=======================================
  Coverage   51.01%   51.01%           
=======================================
  Files          69       69           
  Lines        2074     2074           
  Branches       57       57           
=======================================
  Hits         1058     1058           
  Misses       1016     1016           
Impacted Files Coverage Δ
zio-http/src/main/scala/zhttp/http/Response.scala 69.23% <0.00%> (ø)
...ala/zhttp/service/server/ServerSocketHandler.scala 30.76% <ø> (ø)
...-http/src/main/scala/zhttp/socket/Conversion.scala 0.00% <0.00%> (ø)
...o-http/src/main/scala/zhttp/socket/SocketApp.scala 3.03% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df11745...502c718. Read the comment docs.

@tusharmath tusharmath force-pushed the refactor/remove-error-type-from-socket-app branch from 3a11c13 to 502c718 Compare January 6, 2022 11:32
@github-actions github-actions bot added the enhancement New feature or request label Jan 6, 2022
@amitksingh1490 amitksingh1490 merged commit 1203052 into main Jan 6, 2022
@amitksingh1490 amitksingh1490 deleted the refactor/remove-error-type-from-socket-app branch January 6, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change enhancement New feature or request maintenance Chore or Maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants