Add support for java.nio.file package #47
Conversation
|
@quelgar do you need help with this? maybe we could split this in smaller releasable pieces? |
|
Yeah, this was quite a bit bigger than I anticipated. I’ll push my latest changes, then perhaps we can merge and people can pick up items to work on. I think I have covered pretty much everything, but I haven’t tested much, so there’s likely more work needed. Also needs tests to be written. |
quelgar
force-pushed
the
add-file-package
branch
2 times, most recently
from
17a157b to
dad3d1b
Compare
|
@quelgar it looks like compilation is failing for 2.13 because of |
Yep. I was planning on fixing it with a simple wrapper with 2.12 and 2.13 variants. I've struggled a bit with the tooling for cross-building. Neither IntelliJ or Metals seem to let you pick a different Scala version, looks like I have to temporarily change |
|
@mijicd do you know how to handle this? |
|
@pshemass quick & dirty fix is to use |
quelgar
force-pushed
the
add-file-package
branch
from
dad3d1b to
4b14fe0
Compare
|
Ok, I've rebased, silenced the Still haven't written many tests, I'm afraid. |
|
@quelgar could you list here tests that you want to add I can write some? |
|
Even better, we can tackle them during the upcoming hackathon.
…On Mon, 28 Oct 2019, 19:53 przemyslaw wierzbicki, ***@***.***> wrote:
@quelgar <https://github.com/quelgar> could you list here tests that you
want to add I can write some?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#47?email_source=notifications&email_token=ABD6NODTFT22I2YNCPHENCDQQ4YJ3A5CNFSM4IQERW5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECOAAZA#issuecomment-547094628>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABD6NOGJNPDKAWV2727GZX3QQ4YJ3ANCNFSM4IQERW5A>
.
|
Most of the functionality is wrapped. Some APIs that aren't friendly to functional effects are not wrapped, such as the file copy methods using Java input and output streams. Perhaps a reasonable wrapper API can be found for these in future. Very little in the way of tests yet. The silencer plugin is used to silence warnings about JavaConverters being deprecated, so we can support 2.13 without tedious indirection.
quelgar
force-pushed
the
add-file-package
branch
from
4bbd97b to
9384c60
Compare
|
It would be great to have tests for the more complex stuff, like the directory listing/walking stuff in Probably better to do hackathon work on a new branch, so I'd vote we merge this one now. |
|
Let's merge it then, but, if possible, could you open the test issues and add them to the hackathon board? |
|
Done, issue #100 |
Still very much WIP!. Quite a lot of stuff still to fix up.This is now in decent shape. No tests yet, however.