Publish Docs to The NPM Registry #1001
Conversation
|
This is ready for review. |
project/plugins.sbt
Outdated
| @@ -15,3 +15,6 @@ addSbtPlugin("org.scalameta" % "sbt-mdoc" | |||
| addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.5.0") | |||
| addSbtPlugin("pl.project13.scala" % "sbt-jcstress" % "0.2.0") | |||
| addSbtPlugin("pl.project13.scala" % "sbt-jmh" % "0.4.3") | |||
| addSbtPlugin("dev.zio" % "zio-sbt-website" % "0.0.0+84-6fd7d64e-SNAPSHOT") | |||
|
|
|||
| resolvers += Resolver.sonatypeRepo("public") | |||
There was a problem hiding this comment.
Isn't this redundant? I thought that it's already present by default.
There was a problem hiding this comment.
I remember it causes the not found issue when downloading snapshot artifacts. I can recheck it.
There was a problem hiding this comment.
For snapshots you need
resolvers ++= Resolver.sonatypeOssRepos("snapshots")(don't use sonatypeRepo anymore, always just sonatypeOssRepos)
There was a problem hiding this comment.
Thank you! I removed that line and it works properly for th zio-prelude project. I need to investigate more to find out why I need to explicitly set the resolver for snapshot versions in some repos.
There was a problem hiding this comment.
You need that ☝️ because you're using snapshot of zio-sbt-website
There was a problem hiding this comment.
In my local machine that works properly, maybe because of cached artifacts. Anyway, I added that line.
|
Thanks for your work on this! 🙏 |
| @@ -110,7 +110,7 @@ jobs: | |||
| with: | |||
| swap-size-gb: 7 | |||
| - name: Check Website Generation | |||
| run: ./sbt docs/docusaurusCreateSite | |||
| run: ./sbt docs/compileDocs | |||
There was a problem hiding this comment.
btw does this also test building the actual website?
There was a problem hiding this comment.
No, not the whole! Right now it only checks the compilation of documents using mdoc. The next level is to check the validation of sidebar.js that is not included in this version of zio-sbt-website plugin.
|
Shall we merge? |
|
@sideeffffect Yes, I'm ready to go! |
No description provided.