Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config from exception when Hikari data source can't be created #429

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

GeorgeII
Copy link
Contributor

@GeorgeII GeorgeII commented Apr 2, 2024

Problem

The config with password is printed in logs when an application can't establish a JDBC connection.

The exact same thing was fixed here: zio/zio-quill#2503
This PR is targeted for Scala 3.

Solution

Remove printing config to stacktrace so that it's fixed in Scala 3 as well.

Notes

Am I right that it will fix the issue for Scala 3?

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes

@getquill/maintainers

@CLAassistant
Copy link

CLAassistant commented Apr 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@guizmaii guizmaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @GeorgeII 🙂

@guizmaii guizmaii merged commit 51bed77 into zio:master Apr 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants