Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicQueryDSL setOpt to support string property #1678

Open
itachi3 opened this issue Oct 23, 2019 · 0 comments · May be fixed by #1679
Open

DynamicQueryDSL setOpt to support string property #1678

itachi3 opened this issue Oct 23, 2019 · 0 comments · May be fixed by #1679

Comments

@itachi3
Copy link

itachi3 commented Oct 23, 2019 •
edited
Loading

Version: (e.g. 3.4.10)
Module: (e.g. quill-core)

setOpt in DynamicQueryDsl currently does not support String property.

def setOpt[T, U](property: Quoted[T] => Quoted[U], value: Option[U])(implicit enc: Encoder[U]): DynamicSet[T, U] = value match { case Some(v) => setValue(property, v) case None => DynamicSetEmpty() }

As an enhancement, we could also add property being String

@getquill/maintainers
itachi3 added a commit to itachi3/quill that referenced this issue Oct 23, 2019
@itachi3
zio#1678 Dynamic query DSL updated
0bd7ac9 
Added an extra method to support `String` properties.
@itachi3 itachi3 linked a pull request Oct 23, 2019 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dynamic query DSL updated itachi3/quill
1 participant
@itachi3