Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic query DSL updated #1679

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

itachi3
Copy link

@itachi3 itachi3 commented Oct 23, 2019

Added an extra method to support String properties.

Fixes #1678

Problem

setOpt method currently doesn't support String properties. This leads to forced use of properties during update / insert

Solution

Since set and setValue already supports String as property. It is enough to just overload the setOpt.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

Added an extra method to support `String` properties.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamicQueryDSL setOpt to support string property
2 participants