Create quill-cassandra-monix #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mosyp
reviewed
Dec 26, 2018
README.md
Outdated
| #### sbt dependencies | ||
| ``` | ||
| libraryDependencies ++= Seq( | ||
| "io.getquill" %% "quill-cassandra-streaming-monix" % "2.6.1-SNAPSHOT" |
There was a problem hiding this comment.
change to quill-cassandra-monix
There was a problem hiding this comment.
Yeah. I agree.
README.md
Outdated
| @@ -2669,6 +2664,20 @@ ctx.session.maxSchemaAgreementWaitSeconds=1 | |||
| ctx.session.addressTranslator=com.datastax.driver.core.policies.IdentityTranslator | |||
| ``` | |||
|
|
|||
| ## quill-cassandra-streaming-monix | |||
build.sbt
Outdated
| ) | ||
| ) | ||
| .dependsOn(`quill-core-jvm` % "compile->compile;test->test") | ||
|
|
||
| lazy val `quill-cassandra-streaming-monix` = | ||
| (project in file("quill-cassandra-streaming-monix")) |
|
Okay. Not sure if I can work on it for a few days but will try. |
|
@deusaquilus No worries then, I'll do it once finish udt |
mosyp
changed the title
io.getquill.CassandraStreamContext into quill-cassandra-streaming-monix module - integrate quill-monix
mosyp
approved these changes
Dec 26, 2018
…d missing overrides into monix jdbc context
|
@fwbrasil @deusaquilus it's okay now, pr build passes |
|
@deusaquilus However there's no tests for |
|
I need to adapt the tests fromCassandraStreamingContext
…On Thu, Dec 27, 2018 at 10:49 AM Mykhailo Osypov ***@***.***> wrote:
@deusaquilus <https://github.com/deusaquilus> However there's no tests
for CassandraMonixContext at all, I cannot do that now since I'm off to
my vacation soon
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1278 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABTliCTU5lyWbVh2wY8Hnp28blpApNmZks5u9OwkgaJpZM4ZhlGg>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #985
Adding integration with
quill-monixintoquill-cassandra-streaming-monix, (#1259) which required some changes tomonix-contextmoving things intomonix-jdbc-context. Bumped up monix version inquill-cassandra-streaming-monixto3.0.0-RC2. Also, wroteCassandraMonixContext.Checklist
README.mdif applicable[WIP]to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormatto make sure that the source files are formatted@getquill/maintainers