Rely on ANSI null-fallthrough where possible #1341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1340
Problem
Explain here the context, and why you're making that change.
What is the problem you're trying to solve?
Check the body of Option
exists
,forall
,map
, andflatMap
to see if there is an instance ofIf
,Infix
, or string-concat inside (this is only done when theConcatBehavior
inFlattenOptionOperation
is set toNonAnsiConcat
since outside of oracle, we don't need to have explicit null checks for every string concationation.Although I am posting the PR now, I would like to wait until Oracle can be merged in #1295
README.md
if applicable[WIP]
to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormat
to make sure that the source files are formatted@getquill/maintainers