Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on ANSI null-fallthrough where possible #1341

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

deusaquilus
Copy link
Collaborator

Fixes #1340

Problem

Explain here the context, and why you're making that change.
What is the problem you're trying to solve?

Check the body of Option exists, forall, map, and flatMap to see if there is an instance of If, Infix, or string-concat inside (this is only done when the ConcatBehavior in FlattenOptionOperation is set to NonAnsiConcat since outside of oracle, we don't need to have explicit null checks for every string concationation.

Although I am posting the PR now, I would like to wait until Oracle can be merged in #1295

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@deusaquilus deusaquilus merged commit 5c32692 into zio:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip null checks where ANSI null-fallthrough still works
2 participants