Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster and more reliable build #213

Merged
merged 1 commit into from
Feb 27, 2016
Merged

Conversation

gustavoamigo
Copy link
Contributor

  • Migrated Docker image to Alpine for faster builds
  • Verifies if databases are ready before running script

* Migrated Docker image to Alpine for faster builds
* Verifies if databases are ready before running script
@gustavoamigo
Copy link
Contributor Author

Really weird, I got this error.

06:26:38.358 [pool-1-thread-1-ScalaTest-running-JdbcEncodingSpec] INFO  i.g.s.jdbc.mysql.package$$anon$1 - SELECT t.v1, t.v2, t.v3, t.v4, t.v5, t.v6, t.v7, t.v8, t.v9, t.v10, t.v11, t.o1, t.o2, t.o3, t.o4, t.o5, t.o6, t.o7, t.o8, t.o9, t.o10, t.o11 FROM EncodingTestEntity t WHERE t.v6 IN (?, ?)
[info]   - long *** FAILED ***0m
[info]     List() did not contain the same elements as List(1, 0) (MysqlAsyncEncodingSpec.scala:39)

@fwbrasil
Copy link
Collaborator

@gustavoamigo thanks for working on this! It's much appreciated. :)

I think there's a concurrency issue in MysqlAsyncEncodingSpec.scala, the calls to prepareEncodingTestEntity outside an in clause don't guarantee ordering.

@gustavoamigo
Copy link
Contributor Author

@fwbrasil All right, at least the docker-compose run setup step went down to 55s from previous 112.81s.

@fwbrasil
Copy link
Collaborator

Awesome! From ~12m to ~9m! 👍

@fwbrasil
Copy link
Collaborator

I'm going to fix the flaky test.

fwbrasil added a commit that referenced this pull request Feb 27, 2016
@fwbrasil fwbrasil merged commit d21b80c into zio:master Feb 27, 2016
@gustavoamigo gustavoamigo deleted the better-build branch February 28, 2016 15:57
@fwbrasil fwbrasil mentioned this pull request Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants