Use relative paths and remove timestamp in queries.sql #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this small PR I want to fix a few of the issues we've had with the queries.sql file. Specifically, I've removed the timestamp from the log, relativized all paths to the project root and added a new config option for the log file location to use the project root directory, which should fix #2323. The absolute paths and timestamps have been a problem for us because because we intended to track the queries.sql file in Git so that we can see changes in the generated queries inside a PR but some of our developers complained that the file was constantly changing to due usernames and timestamps in the file. That said, I'm not sure if that use case is even relevant anymore seeing that you moved the queries.sql file to
/targetby default and subsequent compilations seem to append duplicate log lines to the file instead of overwriting them as before (which makes tracking it in Git pointless).@getquill/maintainers