Add performance tip #2532
Add performance tip #2532
Conversation
jilen
force-pushed
the
compiler_performance_tip
branch
3 times, most recently
from
a431190 to
718019a
Compare
|
Nice catch @jilen! This is very, very useful! |
|
@deusaquilus Yes, my English is poor, it would be great if you can improve the description. |
|
@deusaquilus @jilen I feel like this is a pain for many Quill users and so I'd like to merge this PR. Can we merge it as is? @deusaquilus Can you bring the precision you wanted to bring maybe, please? Also, since 2.13.11, implicit must have explicit type declaration, which seems to go against this trick. How do we solve this issue? Edit: |
|
@jilen Now that Scala 2.13.12 is out, could you please update your PR to explain how to make this trick work with the new version of Scala, please? |
|
@jilen any update on this pr ? |
jilen
force-pushed
the
compiler_performance_tip
branch
2 times, most recently
from
1cd0679 to
b626c70
Compare
|
@jilen Is this ready to be merged? |
jilen
force-pushed
the
compiler_performance_tip
branch
5 times, most recently
from
5bb0d5e to
9514d21
Compare
|
@guizmaii The doc is rewritten. I think we can merge it first if no obvious errors. |
docs/compiler-performance.md
Outdated
| val ctx = SqlMirrorContext(MirrorIdiom, Literal) | ||
|
|
||
| // Prevent using default macro generated query meta instance. | ||
| import ctx.{ materializeQueryMeta => _, _ } |
There was a problem hiding this comment.
Can we use the Scala3 syntax maybe? Or at least show it also? People are probably using the -Xsource:3 flag even if they still use Scala2
Is it:
import ctx.{ materializeQueryMeta => *, * }?
|
@jilen Thanks for this! I just left one comment. Let me know what you think 🙂 |
jilen
force-pushed
the
compiler_performance_tip
branch
from
6aaf8b7 to
6f78d6f
Compare
jilen
force-pushed
the
compiler_performance_tip
branch
from
cbdda9a to
dfa8c1b
Compare
Add a compiler performance tip.