Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI shouldn't fail when secrets are missing in forks #2609

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Sep 21, 2022

Fixes #issue_number

Problem

CI fails miserably when run in forks.

Solution

This adds an extra tiny job to the ci workflow that checks for the secrets that appear to be essential to the build and only sets an output when they're present.

The stages that need those secrets are then conditioned on the presence of the secrets.

Notes

I've also fixed the indentation of the ci.yml file as the one-space indentation makes it really hard to follow the file.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
    • Squashing changes eagerly makes it really hard to review the changes. I'm happy to squash once people are ok w/ the changes themselves.
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@juliano
Copy link
Collaborator

juliano commented Jun 6, 2023

@guizmaii after your changes regarding the ci/release, is this one still useful?

@guizmaii
Copy link
Member

guizmaii commented Jun 13, 2023

@jsoref Can you please rebase on the main branch, please?

@jsoref jsoref force-pushed the ci-secrets-in-forks branch from af7e257 to 127d3b6 Compare June 13, 2023 10:37
@jsoref
Copy link
Contributor Author

jsoref commented Jun 13, 2023

Hmm, by main, I presume you mean master -- there's a main, but it's really behind (quite confusingly)...

@jsoref jsoref force-pushed the ci-secrets-in-forks branch from 127d3b6 to a5a2ca9 Compare June 13, 2023 10:50
@jsoref jsoref force-pushed the ci-secrets-in-forks branch from a5a2ca9 to fb7bd6a Compare June 13, 2023 11:34
Copy link
Member

@guizmaii guizmaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliano juliano merged commit 9ac38b4 into zio:master Jun 28, 2023
@juliano
Copy link
Collaborator

juliano commented Jun 28, 2023

Thank you for the contribution!

@jsoref jsoref deleted the ci-secrets-in-forks branch June 28, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants