Support MySQL 5 dialect #2704
Merged
Support MySQL 5 dialect #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@mahe-ymc Can you rebase your branch and fix conflicts, please? |
mahe-ymc
force-pushed
the
master
branch
2 times, most recently
from
2b91438 to
7528fd0
Compare
|
@guizmaii done |
|
Hi @mahe-ymc, thank you for your contribution here! Can you please add a new set of tests for this dialect, similar to https://github.com/zio/zio-quill/tree/master/quill-jdbc/src/test/scala/io/getquill/context/jdbc/mysql? |
Hi @juliano, please have a look. Thanks! |
juliano
approved these changes
Jul 4, 2023
jilen
pushed a commit
that referenced
this pull request
Jun 11, 2024
* Support MySQL 5 dialect * Introduce MySQL5Dialect type * Tests for MySQL5Dialect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2703
@getquill/maintainers