Support Option.orElse #2790
Merged
Support Option.orElse #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
reviewed
Jun 27, 2023
| @@ -24,7 +25,31 @@ class FlattenOptionOperationSpec extends Spec { // hello | |||
| o.getOrElse(1) | |||
| } | |||
| new FlattenOptionOperation(AnsiConcat, TraceConfig.Empty)(q.ast.body: Ast) mustEqual | |||
| If(BinaryOperation(Ident("o"), EqualityOperator.`_!=`, NullValue), Ident("o"), Constant.auto(1)) | |||
| IfExist(o, o, c1) | |||
There was a problem hiding this comment.
Why are we changing the test here? 🤔
There was a problem hiding this comment.
It's just a simplification, they are equivalent :)
guizmaii
approved these changes
Jun 27, 2023
jilen
pushed a commit
that referenced
this pull request
Jun 11, 2024
* support Option.orElse * ooops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1691
Problem
Quill does not support
Option.orElseSolution
Implemented support for
if columnA.orElse(columnB).forall(_ == value)and
if columnA.orElse(columnB).exists(_ == value)syntax
Notes
Additional notes.
Checklist
README.mdif applicable[WIP]to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormatto make sure that the source files are formatted@getquill/maintainers