Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Block::bestQuat #2896

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Fix Block::bestQuat #2896

merged 2 commits into from
Oct 2, 2023

Conversation

guizmaii
Copy link
Member

Found this thanks to research done in #2886

@deusaquilus
Copy link
Collaborator

This is correct. The bestQuat field is basically a "best effort" quat computation that will be around (and not blow up compilation) even if strict-quat-checking is enabled. The only real situation where this happens is where you have Property(Ident("x", quat = Quat.Unknown), "someProperty") which is invalid because to look up a property from something it has to be a Quat.Product e.g. Property(Ident("x", Quat.Product("Person", "firstName" -> Quat.String)), "firstName").

@guizmaii guizmaii merged commit a986635 into master Oct 2, 2023
13 checks passed
@guizmaii guizmaii deleted the Block_bestQuat branch October 2, 2023 05:24
jilen pushed a commit that referenced this pull request Jun 11, 2024
@guizmaii
Fix Block::bestQuat (#2896)
088f09e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deusaquilus deusaquilus deusaquilus approved these changes

@juliano juliano juliano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guizmaii @deusaquilus @juliano