Remove unused code #2901
Merged
Remove unused code #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
guizmaii
commented
Sep 30, 2023
Comment on lines
-193
to
-199
| val innerContext = | ||
| input match { | ||
| case _: Map => | ||
| nest(source(input, id.name)) | ||
| case _ => | ||
| base(input, id.name, nestNextMap) | ||
| } |
There was a problem hiding this comment.
@deusaquilus Isn't it weird that this code was here but unused? Could this be a bug: this code should be used in the result? Or is it just dead code we can remove?
There was a problem hiding this comment.
I think at some point I needed to check whether input of a groupBy.map(...) is another map i.e. x.map.groupBy.map and do a forced nesting but then the nestNextMap took care of that on a higher level.
deusaquilus
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this thanks to research done in #2886