-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] First H2 Iteration #48
Conversation
Current coverage is
|
@@ -35,6 +35,7 @@ lazy val `quill-jdbc` = | |||
libraryDependencies ++= Seq( | |||
"com.zaxxer" % "HikariCP" % "2.3.9", | |||
"mysql" % "mysql-connector-java" % "5.1.36" % "test", | |||
"com.h2database" % "h2" % "1.4.190" % "test", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting
It's looking great! Could you also review the SqlIdiom to check if there are other things that could be different in h2? We don't have integration tests for all sql features. |
Thanks for the feedback. I'll get to it asap. |
@janheise Any news on this? I'm planning to cut a release soon and this PR seems almost ready, it'd be nice to include it. |
Hi Flavio, would love to do it, but currently I'm swamped by work. (You catch me I'll see what I can do next week. Jan On 17.01.2016 10:42, Flavio W. Brasil wrote:
|
@janheise no worries at all! Thanks for the feedback and good luck! :) |
Would someone be interested in continuing the work on this branch? It's open for too long, it'd be sad to have to close this. |
I will do it, I always miss proper H2 support in other libraries and this seems almost ready. |
I have created a local branch from this PR, as it's not possible to push my changes to this PR I will create one as soon as it's ready. |
Ok, I'm closing this one for now. |
Hi Flavio,
please take a look. It seems to run the tests fine but hasn't been further tested. Please note that I put the schema in quill-jdbc/src/test/resources so that I only have to rebuild this package in case of changes and also because I think it's jdbc-test related. Also, I can easily load it via the classpath for an in-memory instance of H2.
Jan