Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Command HRANDFIELD #342

Closed
3 tasks
hcwilhelm opened this issue Apr 8, 2021 · 2 comments · Fixed by #370
Closed
3 tasks

Missing Command HRANDFIELD #342

hcwilhelm opened this issue Apr 8, 2021 · 2 comments · Fixed by #370
Labels
enhancement New feature or request

Comments

@hcwilhelm
Copy link
Contributor

According to https://redis.io/commands/hrandfield Redis support the command HRANDFIELD, but this command is missing in the Hashes API.

Tasks

  • Implement the command
  • Add tests for the command
  • Add support for this command to the TestExecutor
@hcwilhelm hcwilhelm added the enhancement New feature or request label Apr 14, 2021
jgoday added a commit to jgoday/zio-redis that referenced this issue May 7, 2021
@jgoday
zio#342: Implement hrandfield command and support it in TestExecutor
dd1b08e
@jgoday
Copy link
Contributor

jgoday commented May 7, 2021

@hcwilhelm I have try to implement this with this PR #370.
I have implemented two different methods depending on the return value (field or array of fields).
Is this a valid approach ?

@hcwilhelm
Copy link
Contributor Author

@jgoday i will review it in the next couple of days. But from what you described this approach sounds right to me. We split out different methods depending on the return type.

@mijicd mijicd mentioned this issue May 10, 2021
Merged
mijicd pushed a commit that referenced this issue May 11, 2021
@jgoday
#342: Implement hrandfield command and support it in TestExecutor (#370)
02ad6ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#342: Implement hrandfield command and support it in TestExecutor jgoday/zio-redis
2 participants
@jgoday @hcwilhelm