-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the XINFO command #301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxnu-liguobin
force-pushed
the
support-xinfo-cmd
branch
from
March 7, 2021 05:57
0480b6e
to
7e8f4d6
Compare
anovakovic01
requested changes
Mar 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @jxnu-liguobin! With few changes, it will be ready for merge.
jxnu-liguobin
force-pushed
the
support-xinfo-cmd
branch
from
March 13, 2021 15:37
373fd2e
to
d1877d2
Compare
@anovakovic01 Please take a look |
anovakovic01
approved these changes
Mar 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#233
Refer to the design of jedis.It provide three method(sub command) as follows:
The
full
option are not included.Redis documents tell us that we can't rely on the number and order of returned fields, and we should record undefined fields. This is different from the implementation of jedis, in which all the original records are stored in a
Map[String, Object]
.Use
undefined
to record potentially unsupported fields.