Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add testExecutor for hyperLogLog #303

Merged
merged 2 commits into from
Mar 6, 2021
Merged

add testExecutor for hyperLogLog #303

merged 2 commits into from
Mar 6, 2021

Conversation

jxnu-liguobin
Copy link
Collaborator

@jxnu-liguobin jxnu-liguobin commented Mar 5, 2021 •
edited by mijicd
Loading

Closes #193

@jxnu-liguobin jxnu-liguobin requested a review from a team as a code owner March 5, 2021 09:34
mijicd
mijicd reviewed Mar 5, 2021
View reviewed changes
Copy link
Member

@mijicd mijicd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one super small nit, other than that looks good to go.

redis/src/main/scala/zio/redis/TestExecutor.scala Outdated Show resolved Hide resolved
@mijicd mijicd merged commit ac16583 into zio:master Mar 6, 2021
@jxnu-liguobin jxnu-liguobin deleted the hyperLogLog-test-executor branch March 6, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mijicd mijicd mijicd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hyperloglog api to test executor
2 participants
@jxnu-liguobin @mijicd