List api test executor #328
Conversation
Fix scan commands (zio#321)
hcwilhelm
force-pushed
the
list-api-test-executor
branch
from
d14eef0 to
a187233
Compare
|
|
||
| private[redis] final class TestExecutor private ( | ||
| lists: TMap[String, Vector[String]], |
There was a problem hiding this comment.
I'd use Chunk instead of Vector.
There was a problem hiding this comment.
Ok changed to Chunk
| private def errResponse(cmd: String): RespValue.BulkString = | ||
| RespValue.bulkString(s"(error) ERR wrong number of arguments for '$cmd' command") | ||
|
|
||
| private def onConnection(command: String, input: Chunk[RespValue.BulkString])( | ||
| res: => RespValue.BulkString | ||
| ): USTM[BulkString] = STM.succeedNow(if (input.isEmpty) errResponse(command) else res) | ||
|
|
||
| private[this] def runCommand(name: String, input: Chunk[RespValue.BulkString]): STM[RedisError, RespValue] = { | ||
| private[this] def runCommand(name: String, input: Chunk[RespValue.BulkString]): USTM[RespValue] = { |
There was a problem hiding this comment.
We should make sure no unsafe calls are made, e.g. head on potentially empty chunk. It can (and should) be done in a separate pull request.
There was a problem hiding this comment.
I am not sure if I understand what you are trying to say here. From my point of view, we statically know which inputs we feed into each command and therefore we are able to decode the input even with the use of unsafe operations like head etc. How do you imagine that we ensure that no unsafe calls are made?
There was a problem hiding this comment.
What I meant is double-checking if we know statically (last time I took a look there were quite a few head calls), and if now, changing the type to NonEmptyChunk :). If there's nothing to be done here, it's a no-op (even better :) ).
There was a problem hiding this comment.
Alright got it. But as you said this can be done in a follow-up PR.
Co-authored-by: Dejan Mijić <dmijic@acm.org>
List api test executor (zio#328)
Closes: #195
Support all currently implemented List API Commands including the Blocking commands.
Two commands are missing in the API and thus not included in this PR. See : #324 #325