Support GETEX and GETDEL #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcwilhelm
reviewed
Apr 6, 2021
hcwilhelm
reviewed
Apr 6, 2021
hcwilhelm
reviewed
Apr 6, 2021
hcwilhelm
reviewed
Apr 7, 2021
hcwilhelm
reviewed
Apr 7, 2021
hcwilhelm
reviewed
Apr 7, 2021
hcwilhelm
reviewed
Apr 7, 2021
hcwilhelm
reviewed
Apr 7, 2021
hcwilhelm
reviewed
Apr 7, 2021
| _ <- ZIO.sleep(20.millis) | ||
| res <- get(key) | ||
| } yield assert(res.isDefined)(equalTo(true)) && assert(exists)(equalTo(Some(value))) | ||
| } @@ eventually, |
There was a problem hiding this comment.
Just a question why is this test @eventually?
There was a problem hiding this comment.
This is because sleep is unreliable and subject to CPU and thread scheduling. 20ms is likely to cause failure. Here, it is similar to CAS. (guess)
There was a problem hiding this comment.
Ah true, I forgot that we use the Live Clock in these tests.
mijicd
reviewed
Apr 11, 2021
| } | ||
| case object GetExInput extends Input[(String, Expire, Duration)] { | ||
| override private[redis] def encode(data: (String, Expire, Duration)): Chunk[RespValue.BulkString] = | ||
| case class GetExPersistInput[K: Schema]() extends Input[(K, Boolean)] { |
| case object GetExInput extends Input[(String, Expire, Duration)] { | ||
| override private[redis] def encode(data: (String, Expire, Duration)): Chunk[RespValue.BulkString] = | ||
| case class GetExPersistInput[K: Schema]() extends Input[(K, Boolean)] { | ||
| override private[redis] def encode(data: (K, Boolean))(implicit codec: Codec): Chunk[RespValue.BulkString] = |
There was a problem hiding this comment.
Let's remove override private. I noticed that some of the recently added inputs are using it, but please remove it everywhere together with the ones from this PR.
|
Please mark all test wich use generators eg |
|
👍 |
mijicd
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #334