Test executor sortedsets #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 5, 2021
Conflicts: redis/src/main/scala/zio/redis/TestExecutor.scala redis/src/main/scala/zio/redis/api/SortedSets.scala redis/src/main/scala/zio/redis/options/Shared.scala redis/src/test/scala/zio/redis/ApiSpec.scala redis/src/test/scala/zio/redis/SortedSetsSpec.scala
mijicd
reviewed
May 12, 2021
| case api.SortedSets.ZAdd => | ||
| val key = input(0).asString | ||
|
|
||
| val updateOption = input.map(_.asString).find { |
There was a problem hiding this comment.
Does it need conversion to string? Also, | might make it cleaner:
case "XX" | "NX" | "LT" | "GT" => true
case _ => false
Comment on lines
+1036
to
+1038
| val optionsCount = updateOption.map(_ => 1).getOrElse(0) + changedOption.map(_ => 1).getOrElse(0) + incrOption | ||
| .map(_ => 1) | ||
| .getOrElse(0) |
There was a problem hiding this comment.
Please use fold instead of map + getOrElse. This remark applies generally :).
Ok, that's good. I find it way easier to work with the map where I have access to both the value and the score. And so far I could satisfy all the tests I allowed to run ;) And yes I fully understand this is a giant PR and the sorted set Implementation has by far the most lines of code, although I am sure there is a lot of duplication. |
mijicd
previously approved these changes
Jun 7, 2021
hcwilhelm
force-pushed
the
test-executor-sortedsets
branch
from
eb123f1 to
46dc590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SortedSets API support for the TestExecutor backed by a Map[Element, Score]
I found it easier to have a Map of Element -> Score as the underlying data structure than for example a scala TreeSet.
The implementation is not complete at this point but I wanted to create a PR anyways to get some feedback.
I am struggling with implementing full SortedSet API support because some commands support an enormous amount of
Options and also for some commands It is not directly obvious how they should work.