Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement zRandMember #369

Merged
merged 5 commits into from
May 6, 2021
Merged

Implement zRandMember #369

merged 5 commits into from
May 6, 2021

Conversation

jxnu-liguobin
Copy link
Collaborator

@jxnu-liguobin jxnu-liguobin commented May 5, 2021

Closes #353

Similar to other commands with WITHSCORES option, two commands are used to distinguish different return types.
But the special point of this command is that no matter what kind of return structure is, it may be nil.
I am very surprised about this. The document describes that when it is an array(with count), it should return an empty array.

I found it in my local test, so I had to wrap the array with Option.(Hope to have better opinions)

@jxnu-liguobin jxnu-liguobin requested a review from a team as a code owner May 5, 2021 15:02
@jxnu-liguobin jxnu-liguobin changed the title close #353 Implement zRandMember May 5, 2021
@mijicd mijicd merged commit 03fd8f4 into zio:master May 6, 2021
@jxnu-liguobin jxnu-liguobin deleted the dev branch May 26, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Command ZRANDMEMBER
2 participants