Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'GET' option in 'SET' command #801

Merged
merged 4 commits into from
Apr 4, 2023

Conversation

drmarjanovic
Copy link
Collaborator

Closes #222

@drmarjanovic drmarjanovic marked this pull request as ready for review April 4, 2023 11:48
@drmarjanovic drmarjanovic requested a review from a team as a code owner April 4, 2023 11:48
Comment on lines 29 to 46
test("setGet with the existing key and int value") {
for {
redis <- ZIO.service[Redis]
key <- uuid
_ <- redis.set(key, 1)
v <- redis.setGet(key, 2)
} yield assert(v)(isSome(equalTo(1)))
},
test("setGet with the existing key and string value") {
for {
redis <- ZIO.service[Redis]
value <- uuid
key <- uuid
_ <- redis.set(key, value)
newValue <- uuid
v <- redis.setGet(key, newValue)
} yield assert(v)(isSome(equalTo(value)))
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are redundant.

@drmarjanovic drmarjanovic marked this pull request as draft April 4, 2023 12:11
@drmarjanovic drmarjanovic marked this pull request as ready for review April 4, 2023 12:20
@drmarjanovic drmarjanovic merged commit afa5d93 into zio:master Apr 4, 2023
@drmarjanovic drmarjanovic deleted the task-support-set-get branch April 5, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GET option to the SET command
2 participants