Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant benchmarks #811

Merged
merged 2 commits into from
Apr 9, 2023
Merged

Conversation

mijicd
Copy link
Member

@mijicd mijicd commented Apr 9, 2023

Summary

  • removed redundant benchmarks
  • dropped unnecessary library dependencies

Description

So far, we've been benchmarking individual operations across multiple client libraries. While there was some variance among the absolute values, their orders of magnitude were more or less the same. Instead of proceeding with such an approach, we should construct more specific benchmarks, i.e., ones that exercise critical parts of our code.

Note that the new approach would allow us to run our benchmark suite as part of the CI.

@mijicd mijicd marked this pull request as ready for review April 9, 2023 18:16
@mijicd mijicd requested a review from a team as a code owner April 9, 2023 18:16
@drmarjanovic drmarjanovic merged commit edbf012 into zio:master Apr 9, 2023
@mijicd mijicd deleted the feature/benchmarks-ci branch March 15, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants