Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify 'Value' and 'Unknown' command arguments #815

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Unify 'Value' and 'Unknown' command arguments #815

merged 3 commits into from
Apr 12, 2023

Conversation

drmarjanovic
Copy link
Collaborator

Description:

  • Instead of Unknown and Value use Value only.
  • Sorted Input alphabetically.
  • Fixed minor typos.

@drmarjanovic drmarjanovic requested a review from a team as a code owner April 10, 2023 09:22
@mijicd
Copy link
Member

mijicd commented Apr 11, 2023

@anatolysergeev Please take a look at this PR, I'm not sure whether or not it matches your idea about command arguments.

@anatolysergeev
Copy link
Collaborator

anatolysergeev commented Apr 12, 2023 •
edited
Loading

I add Unknown value because i don't check all command, some of them was ambiguous and don't know how that can affect, everything, that's why i was honest with my self and types to do in Unknown.
If we want to delete that, It's ok with me.

@drmarjanovic drmarjanovic merged commit 83f43c3 into zio:master Apr 12, 2023
@drmarjanovic drmarjanovic deleted the task-unify-value-and-unknown branch April 12, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anatolysergeev anatolysergeev anatolysergeev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drmarjanovic @mijicd @anatolysergeev