Rename zio-redis-it's BaseSpec to avoid confusion with test's BaseSpec #980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would it be correct to rename
zio.redis.BaseSpec
insidemodules/redis-it/src/test/scala/zio/redis/BaseSpec.scala
?If so, this PR does it.
The problem is that IntelliJ IDEA imports sbt projects incorrectly and adds an implicit
test->test
dependency to all dependent modules. This leads to confusingzio.redis.BaseSpec
inmodules/redis/src/test/scala/zio/redis/BaseSpec.scala
andmodules/redis-it/src/test/scala/zio/redis/BaseSpec.scala
. Also, test's BaseSpec wins over it's BaseSpec.This problem only affects IJ IDEA, for example VSCode + Metals works as expected.
An alternative solution might be to rename
zio.redis
package for itegration tests to something likezio.redis_it
.