Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename zio-redis-it's BaseSpec to avoid confusion with test's BaseSpec #980

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

maizy
Copy link
Contributor

@maizy maizy commented Jul 28, 2024

Would it be correct to rename zio.redis.BaseSpec inside modules/redis-it/src/test/scala/zio/redis/BaseSpec.scala?

If so, this PR does it.

The problem is that IntelliJ IDEA imports sbt projects incorrectly and adds an implicit test->test dependency to all dependent modules. This leads to confusing zio.redis.BaseSpec in modules/redis/src/test/scala/zio/redis/BaseSpec.scala and modules/redis-it/src/test/scala/zio/redis/BaseSpec.scala. Also, test's BaseSpec wins over it's BaseSpec.

This problem only affects IJ IDEA, for example VSCode + Metals works as expected.

An alternative solution might be to rename zio.redis package for itegration tests to something like zio.redis_it.

@maizy maizy requested a review from a team as a code owner July 28, 2024 08:21
@CLAassistant
Copy link

CLAassistant commented Jul 28, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mijicd mijicd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename to IntegrationSpec then. Otherwise LGTM!

@maizy maizy force-pushed the fix-base-it-spec branch from 8e514f0 to 72806ac Compare July 28, 2024 08:30
@mijicd mijicd enabled auto-merge (squash) July 28, 2024 08:37
@mijicd mijicd merged commit 637377d into zio:master Jul 28, 2024
11 checks passed
@maizy maizy deleted the fix-base-it-spec branch July 28, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants