Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mima checking #824

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Add mima checking #824

merged 5 commits into from
Apr 23, 2024

Conversation

IvanFinochenko
Copy link
Contributor

Issue #750

@IvanFinochenko IvanFinochenko requested a review from a team as a code owner April 23, 2024 11:56
@grouzen
Copy link
Contributor

grouzen commented Apr 23, 2024

@IvanFinochenko Hello! Thanks for the contribution!

A few questions/suggestions.
I believe this PR is missing the CI part to run the check, which is a mimaCheck alias you've added.
This can't be done via amending ci.yml directly since we're using sbt-zio plugin that generates it for us. It means we must use one of the available sbt-zio directives to include the mimaCheck command in the CI pipeline.
After doing this, we just need to set mimaFailOnProblem to false until we release the 3.0.0 version.
That's just how I see it. I hope it makes sense.

@IvanFinochenko
Copy link
Contributor Author

@grouzen Hello! Thanks for suggestions.
I have fixed it.

@grouzen grouzen linked an issue Apr 23, 2024 that may be closed by this pull request
@grouzen grouzen merged commit 5319937 into zio:series/2.x Apr 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure MIMA to fail the build on backward incompatible code changes.
2 participants