feat: Allow the archive offset behavior of the reader to be configured. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reading the PR guidelines, I realize that I need to sign my commit. I'll add my keys and do that (though it may be in 2 weeks because I'm going to be away). |
Pr0methean
requested changes
May 10, 2024
|
Be aware that #93 may cause conflicts with this PR if it's merged first. |
Pr0methean
added
the
Please address review comments
|
@afranchuk When should we expect another revision of this PR? An ETA will be helpful for planning around the other major PRs that are currently open. |
Pr0methean
reviewed
May 24, 2024
|
@Pr0methean I'm working on cleaning it up now (just returned yesterday). |
Aside from supporting the current behavior which allows archives to be preceded by arbitrary data (added in fc749a09), this also allows detection of the offset to use by checking whether a central directory header is at the expected location. This is configurable because if the behavior were based only on detection, there could be false positives if archive data happened to contain a central directory header at the right spot.
afranchuk
force-pushed
the
configure-archive-offset
branch
from
9e1426c
to
a8875b0
Compare
afranchuk
commented
May 29, 2024
Pr0methean
approved these changes
May 29, 2024
Pr0methean
added
waiting to be automatically merged
Pr0methean
removed
the
waiting to be automatically merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from supporting the current behavior which allows archives to be preceded by arbitrary data (added in fc749a09), this also allows detection of the offset to use by checking whether a central directory header is at the expected location. This is configurable because if the behavior were based only on detection, there could be false positives if archive data happened to contain a central directory header at the right spot.
The motivation for this was to support slightly non-standard central directory locations (such as described here).