-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support XZ decompression #199
Conversation
426d31f
to
000ea13
Compare
599ddd1
to
6286be5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good.
97b3d8b
to
fe0b7c0
Compare
All done |
b658406
to
e571a82
Compare
Head branch was pushed to by a user without write access
Thanks for your contribution! I'm hoping to merge and release it within the next 24 hours. |
CI failed but it seems to come from mainline. |
@Pr0methean Hi, I found lzma-rust which supports partial decompression and BCJ, and most importantly, it supports compression. Maybe you are interested in using it instead? |
I have an ugly implementation to use But it's not panic-free so I am not opening a PR. Maybe you could build upon it. |
Opened an issue to consider |
Thanks. It is reasonable to use lzma-rs for now and later migrates to lzma-rust for both lzma and xz (and add compression support). |
Update: It may take another day or two to merge this, since I first need to generate new fuzz corpora with smaller inputs so the fuzz tests can run faster, and the scripts I'm using to do so may still need debugging. |
I dont think the repo settings are correct here. According to the github documentation:
If merge queue is set, we dont need to enable Also the timeout is not correctly set while a time-consuming fuzz test is checked, and the checks nearly exceeds the time limit of Github Action (6h). If merge queue is set, some status check can be moved to merge queue while PR check can only contain neccessary ones (like format and compilation without unit test). I think we could disable |
Actually |
As for the redundancy of the checks, that's necessary to detect the scenario where two PRs in flight at the same time are compatible with master, but not with each other. |
No description provided.